Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: helm upgrade test #2263

Merged
merged 3 commits into from
Sep 14, 2022
Merged

Conversation

sozercan
Copy link
Member

@sozercan sozercan commented Sep 14, 2022

Signed-off-by: Sertac Ozercan sozercan@gmail.com

What this PR does / why we need it:
Helm upgrade test is currently broken since we are trying to deploy an old chart to Kubernetes v1.25 which doesn't have PSP and PDB API versions from the chart

Error: INSTALLATION FAILED: unable to build kubernetes objects from release manifest: [unable to recognize "": no matches for kind "PodSecurityPolicy" in version "policy/v1beta1", unable to recognize "": no matches for kind "PodDisruptionBudget" in version "policy/v1beta1"]
https://github.com/open-policy-agent/gatekeeper/actions/runs/3055615332/jobs/4928863170

Once GK v3.10.0 is out, we can update base chart to v3.10.0 if we want to test on Kubernetes v1.25. For now, downgrading to Kubernetes 1.24.4 to unblock this test.

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2022

Codecov Report

Base: 54.49% // Head: 54.63% // Increases project coverage by +0.13% 🎉

Coverage data is based on head (13d5d1d) compared to base (08a6263).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2263      +/-   ##
==========================================
+ Coverage   54.49%   54.63%   +0.13%     
==========================================
  Files         111      111              
  Lines        9556     9556              
==========================================
+ Hits         5208     5221      +13     
+ Misses       3947     3937      -10     
+ Partials      401      398       -3     
Flag Coverage Δ
unittests 54.63% <ø> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...onstrainttemplate/constrainttemplate_controller.go 58.75% <0.00%> (+2.15%) ⬆️
pkg/readiness/list.go 91.17% <0.00%> (+11.76%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
This reverts commit 13d5d1d.

Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
@sozercan sozercan merged commit 2bc00bc into open-policy-agent:master Sep 14, 2022
@sozercan sozercan deleted the helm-upgrade-k8s branch September 14, 2022 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants