-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update default auditChunkSize in readme #2303
Conversation
@meons thanks for the PR! Gatekeeper helm chart is autogenerated. Can you revert your current change, and make change in gatekeeper/cmd/build/helmify/static/README.md Line 120 in 512d97e
make manifests and commit and push the changes please?
|
As per values.yaml, the parameter `auditChunkSize` is set to 500. Signed-off-by: Simeon Bobylev <simeon.bobylev@gmail.com> Signed-off-by: Siméon Bobylev <simeon.bobylev@nagra.com>
This reverts commit fc76507. Signed-off-by: Siméon Bobylev <simeon.bobylev@nagra.com>
Signed-off-by: Siméon Bobylev <simeon.bobylev@nagra.com>
@sozercan sorry I should have read https://open-policy-agent.github.io/gatekeeper/website/docs/help/#contributing-to-helm-chart first. Should be fine now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! LGTM
Codecov ReportBase: 53.39% // Head: 53.36% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2303 +/- ##
==========================================
- Coverage 53.39% 53.36% -0.03%
==========================================
Files 116 116
Lines 10174 10174
==========================================
- Hits 5432 5429 -3
- Misses 4322 4324 +2
- Partials 420 421 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
As per values.yaml, the parameter
auditChunkSize
is set to 500.Signed-off-by: Simeon Bobylev simeon.bobylev@gmail.com
What this PR does / why we need it: Documentation fix
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: -