Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: add docs pointers from the demo folder #2314

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

acpana
Copy link
Contributor

@acpana acpana commented Oct 5, 2022

What this PR does / why we need it:

THIS IS A STRING CHANGE. But I think it's useful for folks like me that went straight into the demo folder without looking at / remembering to do the prerequisite and installation steps in the docs. I also want to help further lowering the barrier to entry here by being overly explicit about setting up a k8s cluster.

Which issue(s) this PR fixes

Didn't see any issues referencing this.

@sozercan
Copy link
Member

sozercan commented Oct 5, 2022

@acpana thanks for the PR! looks like PR needs DCO signed

Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR!

@sozercan sozercan merged commit 479e331 into open-policy-agent:master Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants