perf: unset CPU limit #2326
Merged
perf: unset CPU limit #2326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
sozercan
reviewed
Oct 11, 2022
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
Codecov ReportBase: 53.39% // Head: 53.36% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2326 +/- ##
==========================================
- Coverage 53.39% 53.36% -0.03%
==========================================
Files 116 116
Lines 10174 10174
==========================================
- Hits 5432 5429 -3
- Misses 4322 4324 +2
- Partials 420 421 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
maxsmythe
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alex Pana 8968914+acpana@users.noreply.github.com
What this PR does / why we need it:
This diff removes
cpulimits on g8r resources. Unsetting thecpulimit is desirable. This is because a predefined limit for a cgroup impacts the parent cgroup too. In turn, having a set cpu limit can result in weird quota exhaustions, without actually exhaustive the cpu resource.Refs: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#how-pods-with-resource-limits-are-run