feat: allow for log-level to be independently configured #2389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Connor Given <givencp@gmail.com>
sozercan
reviewed
Nov 8, 2022
| @@ -76,7 +76,7 @@ spec: | |||
| - --logtostderr | |||
| - --log-denies={{ .Values.logDenies }} | |||
| - --emit-admission-events={{ .Values.emitAdmissionEvents }} | |||
| - --log-level={{ .Values.logLevel }} | |||
| - --log-level={{ (.Values.controllerManager.logLevel | empty | not) | ternary .Values.controllerManager.logLevel .Values.logLevel }} | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
We can if you want, but from the helm perspective, I don't think it's necessary.
There was a problem hiding this comment.
nit: Would be nice to at least add it to the helm docs here: https://github.com/open-policy-agent/gatekeeper/blob/00bc24f6c5d67b4fa3248f6197dc9726a9436771/cmd/build/helmify/static/README.md
There was a problem hiding this comment.
@congiv can you pls run make manifests again to get the README changes into manifest_staging? Thanks!
| @@ -76,7 +76,7 @@ spec: | |||
| - --logtostderr | |||
| - --log-denies={{ .Values.logDenies }} | |||
| - --emit-admission-events={{ .Values.emitAdmissionEvents }} | |||
| - --log-level={{ .Values.logLevel }} | |||
| - --log-level={{ (.Values.controllerManager.logLevel | empty | not) | ternary .Values.controllerManager.logLevel .Values.logLevel }} | |||
There was a problem hiding this comment.
Yes, if these new values aren't specified, these manifests will still get the value from .Values.logLevel.
Signed-off-by: Connor Given <givencp@gmail.com>
Signed-off-by: Connor Given <givencp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Connor Given givencp@gmail.com
What this PR does / why we need it:
This adds functionality to allow the log level of the audit and controller manager Pods to be independently configured.
Which issue(s) this PR fixes :
Fixes #2262
Special notes for your reviewer: kept
.Values.logLevelfor backward compatibility. This value will still be used if the new, workload specific, values aren't specified.