fix(docs): adjust link to the mutation docs #2445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current link is broken - better point to the website directly. Signed-off-by: Tolleiv Nietsch <github@tolleiv.de>
acpana
approved these changes
Dec 9, 2022
sozercan
reviewed
Dec 9, 2022
| @@ -7,7 +7,7 @@ Compared to using [OPA with its sidecar kube-mgmt](https://www.openpolicyagent.o | |||
| * An extensible, parameterized [policy library](https://open-policy-agent.github.io/gatekeeper-library/website/) | |||
| * Native Kubernetes CRDs for instantiating the policy library (aka "constraints") | |||
| * Native Kubernetes CRDs for extending the policy library (aka "constraint templates") | |||
| * Native Kubernetes CRDs for [mutation](mutation.md) support | |||
| * Native Kubernetes CRDs for [mutation](https://open-policy-agent.github.io/gatekeeper/website/docs/mutation/) support | |||
There was a problem hiding this comment.
thanks for the pr! this intentionally refers to mutation.md, as it is meant to direct to the versioned copy of the mutation page. Linking directly like this will break the versioned redirect.
This link works for me, is it broken for you?
There was a problem hiding this comment.
I am getting this while opening mutation.md from the master. Is the file moved to some other location?
There was a problem hiding this comment.
ah my bad, I thought this was the docs website link, not readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tolleiv Nietsch github@tolleiv.de
What this PR does / why we need it:
This is just a small fix in the README. The current link to the mutations is broken - better point to the website directly.
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: