Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix tagged release test for release-3.11 #2467

Merged
merged 5 commits into from
Dec 19, 2022

Conversation

sozercan
Copy link
Member

@sozercan sozercan commented Dec 15, 2022

Signed-off-by: Sertac Ozercan sozercan@gmail.com

What this PR does / why we need it:
tagged release failed because of external data certs

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
@sozercan sozercan changed the title fix tagged release test ci: fix tagged release test Dec 15, 2022
@sozercan sozercan requested a review from a team December 15, 2022 21:02
@sozercan sozercan changed the title ci: fix tagged release test ci: fix tagged release test for release-3.11 Dec 15, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 53.43% // Head: 53.54% // Increases project coverage by +0.10% 🎉

Coverage data is based on head (14f97e3) compared to base (2fd0473).
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-3.11    #2467      +/-   ##
================================================
+ Coverage         53.43%   53.54%   +0.10%     
================================================
  Files               115      115              
  Lines             10192    10192              
================================================
+ Hits               5446     5457      +11     
+ Misses             4331     4322       -9     
+ Partials            415      413       -2     
Flag Coverage Δ
unittests 53.54% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...onstrainttemplate/constrainttemplate_controller.go 59.80% <0.00%> (+2.63%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

sozercan and others added 4 commits December 15, 2022 13:45
…gent#2463)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
log constraint annotations

Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>

Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ritazh
Copy link
Member

ritazh commented Dec 19, 2022

unit test is failing?

@sozercan sozercan merged commit f7d5888 into open-policy-agent:release-3.11 Dec 19, 2022
@sozercan sozercan deleted the fix-tagged-release branch December 19, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants