-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: audit merge errors #2478
fix: audit merge errors #2478
Conversation
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
8cd96b0
to
1e91e7e
Compare
Codecov ReportBase: 53.25% // Head: 53.48% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2478 +/- ##
==========================================
+ Coverage 53.25% 53.48% +0.22%
==========================================
Files 115 115
Lines 10196 10196
==========================================
+ Hits 5430 5453 +23
+ Misses 4346 4327 -19
+ Partials 420 416 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
} | ||
sb.WriteString(err.Error()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Sertac Ozercan sozercan@gmail.com
What this PR does / why we need it:
mergeErrors
skips the first error when mergingWhich issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: