Add unique ingress host to library #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxsmythe
reviewed
Sep 26, 2019
|
Ah, if metadata.name and metadata.namespace always present, let's just use
those.
…-Torin
On Thu, Sep 26, 2019 at 4:38 PM Max Smythe ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In library/general/uniqueingresshost/template.yaml
<#253 (comment)>
:
> + names:
+ kind: K8sUniqueIngressHost
+ listKind: K8sUniqueIngressHostList
+ plural: k8suniqueingresshost
+ singular: k8suniqueingresshost
+ targets:
+ - target: admission.k8s.gatekeeper.sh
+ rego: |
+ package k8suniqueingresshost
+
+ violation[{"msg": msg}] {
+ input.review.kind.kind == "Ingress"
+ host := input.review.object.spec.rules[_].host
+ ingresses := data.inventory.namespace[_][_]["Ingress"]
+ ingresses[_].spec.rules[_].host == host
+ msg := sprintf("ingress host conflicts with an existing ingress <%v>", [host])
I think I've noticed some inconsistency in whether input.review.name gets
defined or not. It may be worth getting input.review.name by default and
falling back to input.review.object.metadata.name for safety.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#253?email_source=notifications&email_token=AAB2KJP2UMMYQ73QVAOBLSDQLUMUPA5CNFSM4I2IOQ42YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCGC62EY#discussion_r328815638>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAB2KJLO7TUQDB2HIWH5433QLUMUPANCNFSM4I2IOQ4Q>
.
--
-Torin
|
|
Sadly, I'm not sure they are always present. |
ritazh
force-pushed
the
library-ingress-conflict
branch
from
fc8da42 to
02aa1d1
Compare
ritazh
changed the title
maxsmythe
requested changes
Oct 2, 2019
ritazh
force-pushed
the
library-ingress-conflict
branch
from
ac36249 to
f8a5c9a
Compare
|
bump |
tsandall
reviewed
Oct 7, 2019
maxsmythe
reviewed
Oct 8, 2019
maxsmythe
reviewed
Oct 9, 2019
| other := data.inventory.namespace[ns][otherapi]["Ingress"][name] | ||
| otherapi == apis[_] | ||
| other := data.inventory.namespace[ns][otherapiversion]["Ingress"][name] | ||
| re_match("^(extensions|networking.k8s.io).+$", otherapiversion) |
There was a problem hiding this comment.
add a / before the .+$ to guarantee we aren't catching groups like: extensions.something.org
|
LGTM |
maxsmythe
approved these changes
Oct 12, 2019
Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>
Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>
Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>
Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>
Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>
Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>
ritazh
force-pushed
the
library-ingress-conflict
branch
from
8c1dceb to
99ff692
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rita Zhang rita.z.zhang@gmail.com