-
Notifications
You must be signed in to change notification settings - Fork 764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump frameworks for 3.14 #3083
Conversation
c2421f4
to
4ee26d9
Compare
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
4ee26d9
to
8a00860
Compare
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3083 +/- ##
==========================================
- Coverage 52.42% 52.40% -0.02%
==========================================
Files 134 134
Lines 11952 11952
==========================================
- Hits 6266 6264 -2
- Misses 5193 5195 +2
Partials 493 493
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
d8128f4
to
fb0e007
Compare
@@ -292,9 +292,6 @@ jobs: | |||
USE_LOCAL_IMG=true \ | |||
ENABLE_GENERATOR_EXPANSION=true | |||
|
|||
go mod tidy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have seperate workflow for this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Any chance this will be cherry-picked to 3.13 releases? Thanks!
|
@a7i can you open an issue for this please? |
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: