Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update audit and controller manager with pod labels #3240

Merged
merged 5 commits into from Feb 6, 2024
Merged

feat: Update audit and controller manager with pod labels #3240

merged 5 commits into from Feb 6, 2024

Conversation

ghost
Copy link

@ghost ghost commented Jan 29, 2024

What this PR does / why we need it:
Release 3.14.0 does not have the right spacing for pod labels on the audit deployment and controller manager deployment. As such it fails if any values are placed in podLabels

@ghost ghost self-requested a review as a code owner January 29, 2024 16:16
@ghost ghost changed the title Update audit and controller manager with pod labels feat: Update audit and controller manager with pod labels Jan 29, 2024
@sozercan
Copy link
Member

@jbruce-nex thanks for the PR! Gatekeeper helm chart is autogenerated and these changes will be clobbered in the next release. Please refer to Contributing to Helm Chart for modifying the Helm chart.

@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3194281) 54.48% compared to head (0b431b9) 54.39%.
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3240      +/-   ##
==========================================
- Coverage   54.48%   54.39%   -0.10%     
==========================================
  Files         134      134              
  Lines       12329    12329              
==========================================
- Hits         6718     6706      -12     
- Misses       5117     5126       +9     
- Partials      494      497       +3     
Flag Coverage Δ
unittests 54.39% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghost
Copy link
Author

ghost commented Jan 30, 2024

@sozercan - Thanks for the info, I have updated the PR to reflect the changes you suggested.

James Bruce added 4 commits February 1, 2024 09:20
Signed-off-by: James Bruce <james.bruce@ba.com>
Signed-off-by: James Bruce <james.bruce@ba.com>
Signed-off-by: James Bruce <james.bruce@ba.com>
Signed-off-by: James Bruce <james.bruce@ba.com>
Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ritazh
Copy link
Member

ritazh commented Feb 1, 2024

@sozercan @maxsmythe should we include this in 3.15 and cherrypick to 3.14 for a new patch release of 3.14?

@ghost
Copy link
Author

ghost commented Feb 2, 2024

@sozercan @maxsmythe should we include this in 3.15 and cherrypick to 3.14 for a new patch release of 3.14?

Hi @ritazh - version 3.14.0 is currently broken if podLabels contains any values, if that helps to determine which release this should be in

@maxsmythe
Copy link
Contributor

I'm okay with either direction.

@cbugneac-nex
Copy link

Hi @ritazh @maxsmythe just wondering any chance to merge this in next release please ?

@ritazh ritazh merged commit 902a1b4 into open-policy-agent:master Feb 6, 2024
17 checks passed
@ritazh
Copy link
Member

ritazh commented Feb 6, 2024

Hi @ritazh @maxsmythe just wondering any chance to merge this in next release please ?

@jbruce-nex Feel free to cherrypick this to the release-3.15 and the release-3.14 branches.

@ghost
Copy link
Author

ghost commented Feb 21, 2024

@ritazh thanks for this, unfortunately it doesn't help as our policy is to work with stable releases only. Is there an ETA for when this might make it to release?

@ritazh
Copy link
Member

ritazh commented Feb 21, 2024

@jbruce-nex The upcoming release 3.16 is targeted for end of April. If you need this fix now, my recommendation would be to cherrypick this to the release-3.15 and the release-3.14 branches so we can cut a patch version for these stable releases.

@ritazh
Copy link
Member

ritazh commented Mar 12, 2024

@jbruce-nex @cbugneac-nex Gatekeeper v3.14.1 and 3.15.1 are now available with this fix.

leewoobin789 pushed a commit to softlee-io/gatekeeper that referenced this pull request Apr 1, 2024
…y-agent#3240)

Signed-off-by: James Bruce <james.bruce@ba.com>
Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants