Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add vap generation doc and demo #3363

Merged
merged 5 commits into from
Apr 25, 2024
Merged

Conversation

ritazh
Copy link
Member

@ritazh ritazh commented Apr 23, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>
@ritazh ritazh requested a review from a team as a code owner April 23, 2024 06:18
website/docs/validating-admission-policy.md Outdated Show resolved Hide resolved
website/docs/validating-admission-policy.md Outdated Show resolved Hide resolved
website/docs/validating-admission-policy.md Outdated Show resolved Hide resolved
website/docs/validating-admission-policy.md Show resolved Hide resolved
Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>
Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>
Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after suggestions from others.

Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>
Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>

## Example Constraint Template
To summary, these are potential options when running Gatekeeper:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated this, PTAL @sozercan @JaydipGabani @maxsmythe

Copy link
Contributor

@JaydipGabani JaydipGabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ritazh ritazh merged commit d2644f7 into open-policy-agent:master Apr 25, 2024
4 checks passed
@ritazh ritazh deleted the vap-docs branch April 25, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants