-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: only set matchConditions on webhook when not empty #3412
fix: only set matchConditions on webhook when not empty #3412
Conversation
f8d2c33
to
8e0dc46
Compare
8e0dc46
to
d8fbec0
Compare
@martijnvdp Thanks for the PR! Gatekeeper helm chart is autogenerated when a release is cut. |
5df5d37
to
6444ba6
Compare
thanks i have updated the PR |
7562c9e
to
06d8819
Compare
Signed-off-by: martijnvdp <m.vanderploeg@nl.ccv.eu>
Any updates on this? We are running the ignoreDifferences workaround for now, but would like to get rid of that if possible. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3412 +/- ##
==========================================
- Coverage 54.49% 46.74% -7.76%
==========================================
Files 134 218 +84
Lines 12329 14784 +2455
==========================================
+ Hits 6719 6911 +192
- Misses 5116 7069 +1953
- Partials 494 804 +310
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We are also impacted on |
What this PR does / why we need it:
only set matchConditions on webhooks when the list in values is not empty
empty matchConditions gets ommited by kubernetes and when deploying with argoCD it results in a drift on this property
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #3410
Special notes for your reviewer: