-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: adding k8s-1.30 #3447
ci: adding k8s-1.30 #3447
Conversation
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3447 +/- ##
==========================================
- Coverage 54.49% 48.03% -6.46%
==========================================
Files 134 219 +85
Lines 12329 14844 +2515
==========================================
+ Hits 6719 7131 +412
- Misses 5116 6906 +1790
- Partials 494 807 +313
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
||
make docker-buildx-crds \ | ||
CRD_IMG=gatekeeper-crds:latest \ | ||
GATEKEEPER_NAMESPACE=${{ matrix.GATEKEEPER_NAMESPACE }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we be getting rid of this field?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
matrix.GATEKEEPER_NAMESPCE
does not exists in the workflow. Nor the variable GATEKEEPER_NAMESPACE
is being used in make docker-buildx-crds
rule.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it, thanks
While we are at it, do we want to remove testing on |
I think updating the K8s versions tested would be wise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
.github/workflows/test-gator.yaml
Outdated
@@ -33,7 +33,7 @@ jobs: | |||
strategy: | |||
fail-fast: false | |||
matrix: | |||
KUBERNETES_VERSION: ["1.26.3", "1.27.1", "1.28.0", "1.29.0"] | |||
KUBERNETES_VERSION: ["1.26.15", "1.27.13", "1.28.9", "1.29.4", "1.30.0"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can drop 1.26, it's eol
.github/workflows/workflow.yaml
Outdated
@@ -33,7 +33,7 @@ jobs: | |||
strategy: | |||
fail-fast: false | |||
matrix: | |||
KUBERNETES_VERSION: ["1.26.3", "1.27.1", "1.28.0", "1.29.0"] | |||
KUBERNETES_VERSION: ["1.26.15", "1.27.13", "1.28.9", "1.29.4", "1.30.0"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com> Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com> Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: