Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: adding k8s-1.30 #3447

Merged
merged 14 commits into from
Jul 31, 2024
Merged

ci: adding k8s-1.30 #3447

merged 14 commits into from
Jul 31, 2024

Conversation

JaydipGabani
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
@JaydipGabani JaydipGabani requested a review from a team as a code owner July 11, 2024 21:30
@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.03%. Comparing base (3350319) to head (5e03469).
Report is 105 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (3350319) and HEAD (5e03469). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (3350319) HEAD (5e03469)
unittests 2 1
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3447      +/-   ##
==========================================
- Coverage   54.49%   48.03%   -6.46%     
==========================================
  Files         134      219      +85     
  Lines       12329    14844    +2515     
==========================================
+ Hits         6719     7131     +412     
- Misses       5116     6906    +1790     
- Partials      494      807     +313     
Flag Coverage Δ
unittests 48.03% <ø> (-6.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


make docker-buildx-crds \
CRD_IMG=gatekeeper-crds:latest \
GATEKEEPER_NAMESPACE=${{ matrix.GATEKEEPER_NAMESPACE }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we be getting rid of this field?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

matrix.GATEKEEPER_NAMESPCE does not exists in the workflow. Nor the variable GATEKEEPER_NAMESPACE is being used in make docker-buildx-crds rule.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it, thanks

@JaydipGabani
Copy link
Contributor Author

While we are at it, do we want to remove testing on 1.26 and update to latest minor versions on 1.27, 1.28 & 1.29?

@maxsmythe
Copy link
Contributor

I think updating the K8s versions tested would be wise.

Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JaydipGabani JaydipGabani self-assigned this Jul 24, 2024
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
@@ -33,7 +33,7 @@ jobs:
strategy:
fail-fast: false
matrix:
KUBERNETES_VERSION: ["1.26.3", "1.27.1", "1.28.0", "1.29.0"]
KUBERNETES_VERSION: ["1.26.15", "1.27.13", "1.28.9", "1.29.4", "1.30.0"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can drop 1.26, it's eol

@@ -33,7 +33,7 @@ jobs:
strategy:
fail-fast: false
matrix:
KUBERNETES_VERSION: ["1.26.3", "1.27.1", "1.28.0", "1.29.0"]
KUBERNETES_VERSION: ["1.26.15", "1.27.13", "1.28.9", "1.29.4", "1.30.0"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@ritazh ritazh added this to the v3.17.0 milestone Jul 31, 2024
@sozercan sozercan merged commit 6fdc181 into open-policy-agent:master Jul 31, 2024
11 checks passed
@JaydipGabani JaydipGabani deleted the k8s-130 branch July 31, 2024 20:30
Ankurk99 pushed a commit to Ankurk99/gatekeeper that referenced this pull request Aug 1, 2024
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com>
Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants