fix: Remove crashOnFailureFetchingExpectations flag #3453
Merged
Commits on Jul 22, 2024
-
Shorten message for crashOnFailureFetchingExpectations flag
Signed-off-by: David-Jaeyoon-Lee <davjlee@google.com>
Commits on Jul 23, 2024
-
Change flag to be commented out and replaced with a false constant
The value of the flag is moot so we want to hide it from the user. Signed-off-by: David-Jaeyoon-Lee <davjlee@google.com>
Commits on Jul 24, 2024
-
Add TODOs on crashOnFailureFetchingExpectations
When we support retry count on fetching expectations we want to expose the crashOnFailureFetchingExpectations as a flag instead of a constant. Signed-off-by: David-Jaeyoon-Lee <davjlee@google.com>
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.