Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix dockerfile lint #3474

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

sozercan
Copy link
Member

@sozercan sozercan commented Aug 6, 2024

What this PR does / why we need it:
fix the dockerfile linter
=> WARN: FromAsCasing: 'as' and 'FROM' keywords' casing do not match

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
@sozercan sozercan requested a review from a team as a code owner August 6, 2024 05:49
@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.23%. Comparing base (3350319) to head (697d64a).
Report is 117 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (3350319) and HEAD (697d64a). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (3350319) HEAD (697d64a)
unittests 2 1
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3474      +/-   ##
==========================================
- Coverage   54.49%   48.23%   -6.27%     
==========================================
  Files         134      219      +85     
  Lines       12329    14989    +2660     
==========================================
+ Hits         6719     7230     +511     
- Misses       5116     6947    +1831     
- Partials      494      812     +318     
Flag Coverage Δ
unittests 48.23% <ø> (-6.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sozercan sozercan merged commit 7ec841a into open-policy-agent:master Aug 6, 2024
19 checks passed
@sozercan sozercan deleted the fix-dockerfile-lint branch August 6, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants