-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: adding common function for error reporting for constraint #3486
chore: adding common function for error reporting for constraint #3486
Conversation
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3486 +/- ##
==========================================
- Coverage 54.49% 48.16% -6.33%
==========================================
Files 134 218 +84
Lines 12329 15134 +2805
==========================================
+ Hits 6719 7290 +571
- Misses 5116 7029 +1913
- Partials 494 815 +321
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
if err2 := r.writer.Update(ctx, status); err2 != nil { | ||
log.Error(err2, "could not report constraint error status") | ||
} | ||
reportMetrics = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens to the reportMetrics
flag?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the flag back. This was not supposed to be removed. Good catch!
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #3484
Special notes for your reviewer:
Here is how the constraint status looks after this change -