Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vap error logging for rego only templates, cherry-pick (#3520) #3525

Merged

Conversation

JaydipGabani
Copy link
Contributor

Signed-off-by: martijnvdp m.vanderploeg@nl.ccv.eu
Co-authored-by: Jaydipkumar Arvindbhai Gabani gabanijaydip@gmail.com
(cherry picked from commit 7429d70)

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

@JaydipGabani JaydipGabani requested a review from a team as a code owner September 4, 2024 17:35
Signed-off-by: martijnvdp <m.vanderploeg@nl.ccv.eu>
Co-authored-by: Jaydipkumar Arvindbhai Gabani <gabanijaydip@gmail.com>
(cherry picked from commit 7429d70)
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (release-3.17@d01aa68). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...onstrainttemplate/constrainttemplate_controller.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##             release-3.17    #3525   +/-   ##
===============================================
  Coverage                ?   48.01%           
===============================================
  Files                   ?      219           
  Lines                   ?    15169           
  Branches                ?        0           
===============================================
  Hits                    ?     7284           
  Misses                  ?     7070           
  Partials                ?      815           
Flag Coverage Δ
unittests 48.01% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JaydipGabani JaydipGabani merged commit 0cb7ef2 into open-policy-agent:release-3.17 Sep 6, 2024
18 checks passed
@JaydipGabani JaydipGabani deleted the release-3.17 branch September 6, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants