Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding helm lint ci test #3536

Merged
merged 5 commits into from
Sep 13, 2024

Conversation

JaydipGabani
Copy link
Contributor

@JaydipGabani JaydipGabani commented Sep 9, 2024

fixes #3534

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

Here is a failed CI test - https://github.com/JaydipGabani/gatekeeper/actions/runs/10780703724/job/29897033536

Here is a successful CI test - https://github.com/JaydipGabani/gatekeeper/actions/runs/10780456845

fixes open-policy-agent#3534

Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
@JaydipGabani JaydipGabani requested a review from a team as a code owner September 9, 2024 18:50
@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.05%. Comparing base (3350319) to head (2b505ba).
Report is 140 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (3350319) and HEAD (2b505ba). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (3350319) HEAD (2b505ba)
unittests 2 1
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3536      +/-   ##
==========================================
- Coverage   54.49%   48.05%   -6.45%     
==========================================
  Files         134      218      +84     
  Lines       12329    15167    +2838     
==========================================
+ Hits         6719     7288     +569     
- Misses       5116     7066    +1950     
- Partials      494      813     +319     
Flag Coverage Δ
unittests 48.05% <ø> (-6.45%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sozercan sozercan merged commit b4d2d2c into open-policy-agent:master Sep 13, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CI test to verify lint errors in helm charts
4 participants