chore: remove setting alpha flags out of box #3578
Conversation
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
| - --emit-audit-events={{ .Values.emitAuditEvents }} | ||
| - --log-stats-audit={{ .Values.logStatsAudit }} | ||
| {{ if hasKey .Values "emitAuditEvents" }}- --emit-audit-events={{ .Values.emitAuditEvents }}{{- end }} | ||
| {{ if hasKey Values "logStatsAudit" }}- --log-stats-audit={{ .Values.logStatsAudit }}{{- end }} |
There was a problem hiding this comment.
These flags are in alpha for a long time and has been set for many GK versions. I can remove these changes if this is a breaking concern.
| - --emit-admission-events={{ .Values.emitAdmissionEvents }} | ||
| - --log-stats-admission={{ .Values.logStatsAdmission }} | ||
| {{ if hasKey Values "emitAdmissionEvents" }}- --emit-admission-events={{ .Values.emitAdmissionEvents }}{{- end }} | ||
| {{ if hasKey Values "logStatsAdmission" }}- --log-stats-admission={{ .Values.logStatsAdmission }}{{- end }} |
There was a problem hiding this comment.
These flags are in alpha for a long time and has been set for many GK versions. I can remove these changes if this is a breaking concern.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3578 +/- ##
==========================================
- Coverage 54.49% 47.71% -6.78%
==========================================
Files 134 221 +87
Lines 12329 18699 +6370
==========================================
+ Hits 6719 8923 +2204
- Misses 5116 8934 +3818
- Partials 494 842 +348
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
| @@ -218,6 +218,9 @@ information._ | |||
| | audit.readinessTimeout | Timeout in seconds for audit's readiness probe | `1` | | |||
| | audit.livenessTimeout | Timeout in seconds for the audit's liveness probe | `1` | | |||
| | audit.logLevel | The minimum log level for audit, takes precedence over `logLevel` when specified | `null` | | |||
| | audit.enablePubsub | (alpha) Enabled pubsub to publish messages | `false` | | |||
There was a problem hiding this comment.
nit: can you pls make this consistent with other fields that currently have (alpha feature). prepend (alpha) is better IMO.
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
What this PR does / why we need it: We should avoid setting flags that are alpha unless explicitly added.
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #3483
Special notes for your reviewer: