Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixing nil pointer error when converting VAPB from v1beta1 to v1 #3754

Merged

Conversation

JaydipGabani
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #3753

Special notes for your reviewer:

Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
@JaydipGabani JaydipGabani requested a review from a team as a code owner December 17, 2024 19:27
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.68%. Comparing base (3350319) to head (ec9c711).
Report is 217 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (3350319) and HEAD (ec9c711). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (3350319) HEAD (ec9c711)
unittests 2 1
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3754      +/-   ##
==========================================
- Coverage   54.49%   47.68%   -6.82%     
==========================================
  Files         134      236     +102     
  Lines       12329    19924    +7595     
==========================================
+ Hits         6719     9500    +2781     
- Misses       5116     9529    +4413     
- Partials      494      895     +401     
Flag Coverage Δ
unittests 47.68% <100.00%> (-6.82%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ritazh ritazh merged commit 14e6c8a into open-policy-agent:master Dec 18, 2024
17 checks passed
@JaydipGabani JaydipGabani deleted the vapb-version-conversion branch December 18, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Constraint with a namespaceSelector that generates VAPB returns nil
4 participants