chore: adding annotation to generate VAPB right away once the waiting window is over to protect against clock skews #3773
+49
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is over to protect against clock skews Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3773 +/- ##
==========================================
- Coverage 54.49% 47.69% -6.81%
==========================================
Files 134 236 +102
Lines 12329 19942 +7613
==========================================
+ Hits 6719 9511 +2792
- Misses 5116 9536 +4420
- Partials 494 895 +401
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
maxsmythe
approved these changes
Jan 15, 2025
| @@ -65,9 +65,12 @@ import ( | |||
|
|
|||
| const ( | |||
| BlockVAPBGenerationUntilAnnotation = "gatekeeper.sh/block-vapb-generation-until" | |||
| VAPBGenerationAnnotation = "gatekeeper.sh/vapb-generation" | |||
There was a problem hiding this comment.
nit: vapb-generation-lock or similar to more clearly specify intent
There was a problem hiding this comment.
How about vapb-generation-state?
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #3683
Special notes for your reviewer: