Fix by-name namespace matching #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ritazh
reviewed
Jan 21, 2020
Part of the reason namespace selectors needed to be fixed is that "Namespace" isn't populated in an admission request if the request is for a namespace. Also, "Name" isn't populated in the admission request for namespace requests. Signed-off-by: Max Smythe <smythe@google.com>
maxsmythe
force-pushed
the
fix-ns-matching
branch
from
2a15f44 to
6a583ac
Compare
|
@ritazh Explanation SGTY? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the reason namespace selectors needed to be fixed
is that "Namespace" isn't populated in an admission request
if the request is for a namespace. Also, "Name" isn't populated
in the admission request for namespace requests.
Signed-off-by: Max Smythe smythe@google.com