check abi versions #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srenatus
force-pushed
the
sr/check-abi-versions
branch
from
3940710 to
80ad533
Compare
Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
Variables starting with an underscore indicate that they're not used. So, we use it for ctx (unused), and don't use it for _1, _2, ... args. Also renames policy_wasm -> policyWasm. Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
srenatus
force-pushed
the
sr/check-abi-versions
branch
from
80ad533 to
9394232
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In open-policy-agent/opa#3142, we'll be introducing an ABI version.
This change checks that the version is what we currently expect. Also serves as an example on how to use the global variable in nodejs.