Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When running opa test with --explain specified the trace should be displayed #2069

Closed
patrick-east opened this issue Feb 7, 2020 · 0 comments · Fixed by #2267
Closed

When running opa test with --explain specified the trace should be displayed #2069

patrick-east opened this issue Feb 7, 2020 · 0 comments · Fixed by #2267
Assignees
@patrick-east
Labels
good first issue usability

Comments

@patrick-east
Copy link
Contributor

Expected Behavior

If I run something like:

opa test --explain notes .

I would expect that the explanation (trace) to be displayed.

Actual Behavior

The -v flag must also be specified to get the trace to be displayed.

Proposed Change

When the --explain option is specified it implies -v for the output.
@tsandall tsandall mentioned this issue Feb 17, 2020
Closed
patrick-east added a commit to patrick-east/opa that referenced this issue Apr 3, 2020
@patrick-east
cmd/test: --explain now turns on verbose output
1e56328 
Rather than requiring both `--explain` and `--verbose`/`-v` a user
just needs to pass in `--explain` and verbose output will be enabled.

Fixes: open-policy-agent#2069
Signed-off-by: Patrick East <east.patrick@gmail.com>
@patrick-east patrick-east mentioned this issue Apr 3, 2020
Merged
tsandall pushed a commit that referenced this issue Apr 6, 2020
@patrick-east @tsandall
cmd/test: --explain now turns on verbose output
2d22309 
Rather than requiring both `--explain` and `--verbose`/`-v` a user
just needs to pass in `--explain` and verbose output will be enabled.

Fixes: #2069
Signed-off-by: Patrick East <east.patrick@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@patrick-east patrick-east

Labels
good first issue usability
Projects
Open Policy Agent
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve opa test --verbose and --explain flag usage patrick-east/opa
2 participants
@tsandall @patrick-east