Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example for PartialResult is using PartialEval #2294

Closed
itaysk opened this issue Apr 13, 2020 · 2 comments · Fixed by #2508
Closed

Example for PartialResult is using PartialEval #2294

itaysk opened this issue Apr 13, 2020 · 2 comments · Fixed by #2508
Labels
bug good first issue help wanted

Comments

@itaysk
Copy link
Contributor

itaysk commented Apr 13, 2020

The example for PartialResult is using PartialEval. Probably a leftover from the deprecation of PartialEval https://github.com/open-policy-agent/opa/blob/master/rego/example_test.go#L389
@patrick-east
Copy link
Contributor

Good catch @itaysk! we should get that updated.

@sresthas sresthas mentioned this issue Apr 30, 2020
Closed
sresthas added a commit to sresthas/opa that referenced this issue May 2, 2020
@sresthas
example_test: Use PartialResult Fixes open-policy-agent#2294
318f6f8 
Signed-off-by: Srestha Srivastava <sresthasrivastava.ss@gmail.com>
@agarwalrounak
Copy link
Contributor

Can I take up this issue?

gaga5lala added a commit to gaga5lala/opa that referenced this issue Jul 1, 2020
@gaga5lala
rego: use correct PartialResult in test
87dcbfb 
Fixes open-policy-agent#2294

Signed-off-by: Gaga Pan <gaga5lala1013@gmail.com>
@gaga5lala gaga5lala mentioned this issue Jul 1, 2020
Merged
patrick-east pushed a commit that referenced this issue Jul 1, 2020
@gaga5lala @patrick-east
rego: use correct PartialResult in test
fa5e302 
Fixes #2294

Signed-off-by: Gaga Pan <gaga5lala1013@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue help wanted
Projects
Open Policy Agent
Archived in project
Milestone
No milestone
3 participants
@itaysk @patrick-east @agarwalrounak