docs/content: Updated the apis and responses in kubernetes tutorial #3910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: #3821 Signed-off-by: Olamide Omolola <omololaolamidex@gmail.com>
docs/content/kubernetes-tutorial.md
Outdated
| @@ -416,6 +416,8 @@ webhooks: | |||
| service: | |||
| namespace: opa | |||
| name: opa | |||
| admissionReviewVersions: ["v1beta1"] | |||
There was a problem hiding this comment.
Since this is deprecated since 1.16, I'd suggest going with v1 here.
There was a problem hiding this comment.
Whenever I included the v1, the api server rejected it. It only accepts v1beta1 as an allowed version. I will try to figure out why later
There was a problem hiding this comment.
Interesting. You mean it rejected the actual configuration, or it rejected a v1 admissionreview response back from the webhook? Great that you tested it either way!
Signed-off-by: Olamide Omolola <omololaolamidex@gmail.com>
|
@anderseknert, I updated the admissionReviewVersions |
Signed-off-by: Olamide Omolola <omololaolamidex@gmail.com>
anderseknert
previously approved these changes
Oct 26, 2021
Signed-off-by: Olamide Omolola <omololaolamidex@gmail.com>
Fixes: #3821 Signed-off-by: Olamide Omolola <omololaolamidex@gmail.com>
And reference it from the `some` keyword section. Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
The statement is no longer generated by the planner so it is unused at this point. Remove it. Signed-off-by: Torin Sandall <torinsandall@gmail.com>
Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
Tests started failing because the 1000 days had run out. Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
This broke with #3907. Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
LLVM 13, latest wabt and binaryen. Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
Fixes #3910 docs/content: Added v1 to admissionReviewVersion in kubernetes tutorial Signed-off-by: Olamide Omolola <omololaolamidex@gmail.com> docs/content: Updated kube-mgmt tags and admissionReview api Signed-off-by: Olamide Omolola <omololaolamidex@gmail.com> docs/content: updated kubernetes tutorial Signed-off-by: Olamide Omolola <omololaolamidex@gmail.com>
Signed-off-by: Olamide Omolola <omololaolamidex@gmail.com>
olamiko
added a commit
to olamiko/opa
that referenced
this pull request
Oct 26, 2021
Fixes open-policy-agent#3910 and open-policy-agent#3911 Signed-off-by: Olamide Omolola <omololaolamidex@gmail.com> docs/content: Updated envoy tutorials Signed-off-by: Olamide Omolola <omololaolamidex@gmail.com>
anderseknert
pushed a commit
that referenced
this pull request
Oct 26, 2021
dolevf
pushed a commit
to dolevf/opa
that referenced
this pull request
Nov 4, 2021
…licy-agent#3931) Fixes open-policy-agent#3910 and open-policy-agent#3911 Signed-off-by: Olamide Omolola <omololaolamidex@gmail.com> Signed-off-by: Dolev Farhi <farhi.dolev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.