wasm/builder: bump llvm, wabt, binaryen #3908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
tsandall
approved these changes
Oct 25, 2021
|
This usually never gets green and takes a bit too rebuild and publish the image from GHA ... so I've merged it early today to give it a headstart. |
dolevf
pushed a commit
to dolevf/opa
that referenced
this pull request
Nov 4, 2021
LLVM 13, latest wabt and binaryen. Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com> Signed-off-by: Dolev Farhi <farhi.dolev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLVM 13, latest wabt and binaryen.
👉 I've done a test run here (since this won't pass CI, since the image is built ad-hoc, and pushed to docker-hub post-merge).
The Wasm modules differ a bit, I haven't dug in yet. I think some changes to what's inlined and what isn't. There's no significant change in LLVM 13 that necessitates this, except that we should keep tracking new developments to not get stuck.