Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick and release v0.39.1 for gatekeeper #4711

Closed
thomasmckay opened this issue May 26, 2022 · 9 comments
Closed

cherry-pick and release v0.39.1 for gatekeeper #4711

thomasmckay opened this issue May 26, 2022 · 9 comments

Comments

@thomasmckay
Copy link

cherry-pick e9d3828 and release v0.39.1

gatekeeper-3.8 relies on opa-0.39, rather than bumping to opa-0.40 in a 3.8.z it would be better to have the fix backported

Thoughts?

@tsandall
Copy link
Member

We'd recommend just updating to v0.40.0. Is there something in v0.40.0 that you're particularly worried about?

@thomasmckay
Copy link
Author

Nothing specific but bumping to a y-stream in the underlying core tech could be perceived as "risky". A y-stream bump to opa would be better consumed in a y-stream of gatekeeper. In the community meeting there wasn't strong pushback against bumping opa but for future reference, should consumers of opa not expect cve/bug backports? Is there a doc on the threshold?

@anderseknert anderseknert removed the bug label May 27, 2022
@tsandall
Copy link
Member

If GK can update to 0.40 that's preferable. We don't provide a backport guarantee today--but that's not to say we can't do it, e.g., in this case, if there are specific needs for a v0.39.1 release, we're happy to do it.

@tsandall
Copy link
Member

@ritazh @willbeason is GK 3.8 going to update to v0.40?

@willbeason
Copy link
Member

@tsandall I don't think there's any danger in upgrading GK 3.8 to v0.40 in a patch release. I don't have a good understanding of the need for a v0.39.1 release. If there were a specific reason to not upgrade to v0.40 in a patch release, that would be compelling, but in the absence of anything specific it's hard to justify.

I have a PR out for upgrading (future) GK 3.9 to v0.40: open-policy-agent/gatekeeper#2069

@anderseknert
Copy link
Member

OK to close this now?

@willbeason
Copy link
Member

@thomasmckay @maxsmythe ?

@maxsmythe
Copy link
Contributor

v3.9.0-beta.2 is on OPA v0.40.0

https://github.com/open-policy-agent/gatekeeper/blob/24aad6c76af7e661fc7d578684419cf7427fe87d/go.sum#L826

@sozercan didn't want to upgrade OPA on a minor release b/c it could mean a significant change IIRC.

Not sure if that meets @thomasmckay 's goals or not?

@srenatus
Copy link
Contributor

Looks like it's OK to close? We can always re-open 🧹

@srenatus srenatus closed this as not planned Won't fix, can't repro, duplicate, stale Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants