Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade deps, including OPA to v0.40.0 #2069

Merged
merged 4 commits into from
May 31, 2022

Conversation

willbeason
Copy link
Member

Upgrade all dependencies as much as possible without significant code changes or waiting for k8s to upgrade OpenTelemetry.

@willbeason willbeason requested review from ritazh and maxsmythe May 27, 2022 16:23
Will Beason added 2 commits May 27, 2022 16:24
Signed-off-by: Will Beason <willbeason@google.com>
This includes frameworks, and so OPA to v0.40.0

Signed-off-by: Will Beason <willbeason@google.com>
Signed-off-by: Will Beason <willbeason@google.com>
@codecov-commenter
Copy link

Codecov Report

Merging #2069 (165933c) into master (206bbe9) will increase coverage by 0.01%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##           master    #2069      +/-   ##
==========================================
+ Coverage   54.50%   54.51%   +0.01%     
==========================================
  Files         111      111              
  Lines        9470     9470              
==========================================
+ Hits         5162     5163       +1     
  Misses       3921     3921              
+ Partials      387      386       -1     
Flag Coverage Δ
unittests 54.51% <40.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...onstrainttemplate/constrainttemplate_controller.go 58.27% <33.33%> (+0.23%) ⬆️
pkg/webhook/policy.go 37.53% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f26422...165933c. Read the comment docs.

k8s.io/utils v0.0.0-20220210201930-3a6ce19ff2f9
sigs.k8s.io/controller-runtime v0.11.2
sigs.k8s.io/controller-runtime v0.12.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to update the forked controller-runtime?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so - no test failures

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@willbeason willbeason merged commit f597d37 into open-policy-agent:master May 31, 2022
@willbeason willbeason deleted the upgrade-deps branch May 31, 2022 18:00
davis-haba pushed a commit to davis-haba/gatekeeper that referenced this pull request Jul 19, 2022
* Upgrade go/compute

Signed-off-by: Will Beason <willbeason@google.com>

* Upgrade all deps

This includes frameworks, and so OPA to v0.40.0

Signed-off-by: Will Beason <willbeason@google.com>

* Remove unintentional file

Signed-off-by: Will Beason <willbeason@google.com>
Signed-off-by: davis-haba <davishaba@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants