Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

semver docs typo #5012

Closed
tetsuya28 opened this issue Aug 15, 2022 · 1 comment · Fixed by #5059
Closed

semver docs typo #5012

tetsuya28 opened this issue Aug 15, 2022 · 1 comment · Fixed by #5059
Labels

Comments

@tetsuya28
Copy link

Short description

In semver.compare(), found docs typo and I think the following is correct.
1 if b > a;1 if a > b;
Ref: https://www.openpolicyagent.org/docs/latest/policy-reference/#semver

Returns:
result
(number)
-1 if a < b; 1 if b > a; 0 if a == b

@tetsuya28 tetsuya28 added the bug label Aug 15, 2022
@srenatus
Copy link
Contributor

Thanks, good catch. It's defined here:

types.Named("result", types.N).Description("`-1` if `a < b`; `1` if `b > a`; `0` if `a == b`"),
-- would you be up to filing a PR with the fix? 😃

anderseknert added a commit to anderseknert/opa that referenced this issue Aug 29, 2022
Fixes open-policy-agent#5012

Signed-off-by: Anders Eknert <anders@eknert.com>
srenatus pushed a commit that referenced this issue Aug 29, 2022
Fixes #5012.

Signed-off-by: Anders Eknert <anders@eknert.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants