-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
High evaluation time when referencing huge array #5946
Comments
Thanks guys! we really got to the point where this is an actual problem. |
@itayhac 👍 If you're able to share your actual policy where this is problematic, it could be a good test case for the fix. |
@anderseknert unfortunately the actual policy is a client's proprietary. but i will happily test the solution on the actual policy and update the result here. |
Sounds good. The reason I'm asking is that while the problem exposed by the example policy above is real, referencing an array without actually using it.. I guess there are cases where you'll want to know that it's defined, but most often the above example wouldn't make a lot of sense, I think. |
Fixes: open-policy-agent#5946 Signed-off-by: Johan Fylling <johan.dev@fylling.se>
Even when "unused", simply referencing a huge array will have a big impact on evaluation time.
In the above case
data.slow_bundle.index.feeds
is a 10 MB JSON array containing some huge objects. I'd expect a simple reference to not have that kind of impact, as there's no evaluation needed in this case.The text was updated successfully, but these errors were encountered: