Change e2e tests to bind on :0 instead of :8181 #1534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To do this we needed a way to get the actual address that was bound. To do that we needed to refactor the server and runtime code a tad to let us create our own `net.Listener`s and get their address _after_ they had been started. The code is pretty much 1:1 with what is in the official `http` package. Now when the tests run using the helpers to stand up server runtimes they should all be on separate ports.. in theory we could run the unit tests in parallel without concern (for the e2e parts anyway). Fixes: open-policy-agent#1533 Signed-off-by: Patrick East <east.patrick@gmail.com>
ashutosh-narkar
approved these changes
Jul 1, 2019
| return nil, err | ||
| } | ||
| tc.SetKeepAlive(true) | ||
| tc.SetKeepAlivePeriod(3 * time.Minute) |
There was a problem hiding this comment.
NIT: use a const for this instead of 3.
There was a problem hiding this comment.
I left it as-is to match https://golang.org/src/net/http/server.go?s=86961:87002#L3263 I figure the least amount of deviation the better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To do this we needed a way to get the actual address that was bound.
To do that we needed to refactor the server and runtime code a tad
to let us create our own
net.Listeners and get their address afterthey had been started. The code is pretty much 1:1 with what is in the
official
httppackage.Now when the tests run using the helpers to stand up server runtimes
they should all be on separate ports.. in theory we could run the
unit tests in parallel without concern (for the e2e parts anyway).
Fixes: #1533
Signed-off-by: Patrick East east.patrick@gmail.com