Add livenessProbe to demo deployment #1605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the patch! Totally agree that we should have these in the docs. One thing i'm wondering is if, for the sake of consistency, we should have this match up with the default one on the official helm chart https://github.com/helm/charts/blob/master/stable/opa/values.yaml#L159-L172 ? |
|
@patrick-east Thanks, and no problem! 😁 I was torn between keeping the example concise and adding the check. Agree it is likely best to borrow from the chart here though. I've added this in 27f4e7b8f1921d07ff55bd2eade96b8891eec708 |
patrick-east
previously approved these changes
Aug 2, 2019
I expect many install OPA following this guide (as we did). Recent PRs have made steps to 'productionize' this (e.g. [#1435](#1435)) We had an incident involving the controller where a stuck container was not restarted. We would have been helped if a liveness probe was configured. We copied the docs and this is our bad but we'd like to do our best to make sure others don't make the same mistake. I figured it'd be ok to use the health endpoint [here](https://github.com/open-policy-agent/opa/blob/master/docs/content/rest-api.md#health-api) We've made this change and it seems to be working ok for us. Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>
|
👍 Should be good to go now. Thanks. |
patrick-east
approved these changes
Aug 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I expect many install OPA following this guide (as we did). Recent PRs have made steps to 'productionize' this (e.g. #1435)
We had an incident involving the controller where a stuck container was not restarted. We would have been helped if a liveness probe was configured. We copied the docs and this is our bad but we'd like to do our best to make sure others don't make the same mistake.
I figured it'd be ok to use the health endpoint here
We've made this change and it seems to be working ok for us.