plugins/bundle: Include last successful request timestamp in status #2076
+62
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrick-east
previously approved these changes
Feb 7, 2020
|
@patrick-east that's true, adding a "last request" timestamp wouldn't hurt and could be nice. I'll update the PR with that and then merge. |
This commit updates the bundle plugin to record the last successful download _attempt_ timestamp in the bundle status. This way Status API implementations can easily check whether the OPA has been able to recently check-in for bundle updates. Fixes open-policy-agent#2009 Signed-off-by: Torin Sandall <torinsandall@gmail.com>
tsandall
dismissed stale reviews from patrick-east and ashutosh-narkar
via
e09effd
patrick-east
approved these changes
Feb 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the bundle plugin to record the last successful
download attempt timestamp in the bundle status. This way Status API
implementations can easily check whether the OPA has been able to
recently check-in for bundle updates.
Fixes #2009
Signed-off-by: Torin Sandall torinsandall@gmail.com