Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add guidance around resource utilization #2310

Merged
merged 1 commit into from
Apr 17, 2020

Conversation

tsandall
Copy link
Member

There are many ways this question can be answered so this is not a
final answer but instead a starting point. In the future we can expand
on this section to include more use-case specific resource utilization
guidance however for the time being this is a good start.

Fixes #1601

Signed-off-by: Torin Sandall torinsandall@gmail.com

patrick-east
patrick-east previously approved these changes Apr 16, 2020
Copy link
Contributor

@patrick-east patrick-east left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Any thoughts around maybe putting a pointer to this in https://www.openpolicyagent.org/docs/latest/deployments/ ?

Copy link
Member

@ashutosh-narkar ashutosh-narkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashutosh-narkar
Copy link
Member

ashutosh-narkar commented Apr 16, 2020

The only comment is in the docs the sections Key Takeaways and Resource Utilization are under the Benchmarking Queries section. They probably should be out of that section.

There are many ways this question can be answered so this is not a
final answer but instead a starting point. In the future we can expand
on this section to include more use-case specific resource utilization
guidance however for the time being this is a good start.

Fixes open-policy-agent#1601

Signed-off-by: Torin Sandall <torinsandall@gmail.com>
@tsandall tsandall dismissed stale reviews from ashutosh-narkar and patrick-east via e3509f1 April 17, 2020 10:51
@tsandall tsandall force-pushed the add-resource-guidance branch from 44ad9b3 to e3509f1 Compare April 17, 2020 10:51
@tsandall
Copy link
Member Author

I've fixed the headers and added a link in the deployment doc.

@tsandall tsandall merged commit 5fd5349 into open-policy-agent:master Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide compute resource guidance for OPA deployments
3 participants