-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugin/rest: Adds AWS Web Identity support #2725
plugin/rest: Adds AWS Web Identity support #2725
Conversation
@patrick-east PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking pretty good 👍
Once the remaining TODO's are finished we should be in good shape.
You'll need to remove the changes from internal/compiler/wasm/opa
, I don't think those should be getting modified from these changes.
I figured. Came from just running |
1b18a93
to
e0edac3
Compare
Added test coverage and some basic documentation. LMK how it looks! |
Aside: Is there a trick to getting my doc changes to show in the preview? Doesn't seem to be showing up. |
They're under the |
71965f6
to
a0a5a3a
Compare
Aha! There we go. |
Changes look good! Do you by chance have pointers to instructions/examples to try this out? |
Sadly the answer is spinning up an IAM role, s3 bucket w/ permissions, and EKS cluster, and then launching an OPA pod on that cluster w/ the approriate annotations on that pods SA. |
@RichiCoder1 did you have a chance to try it out with the full setup? |
Sadly, no. We're launching a big feature and it ate up my time. Reaching the tail end of that though, hoping to circle back around. |
8eee6d9
to
ea01da6
Compare
Finally was able to test! Luckily due to the nature of this change, was able to swipe a token off of my cluster. |
ea01da6
to
f1b8434
Compare
Adds support for signing S3 requests using Web Identity credentials. Specifically supports the Env Var version that's used in EKS IRSA. Closes: open-policy-agent#2463 Signed-off-by: Richard Simpson <richardsimpson@outlook.com>
f1b8434
to
2761665
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting it tested out!
Adds support for signing S3 requests using Web Identity credentials. Specifically supports the Env Var version that's used in EKS IRSA.
Closes: #2462
Remaining Work: