Separate console logger for plugins

[anderseknert]

This allows logging to console for decisions and status (and possibly other use cases) without having to follow the generic --log-level.

Fixes #2733

Signed-off-by: Anders Eknert anders.eknert@bisnode.com

[ashutosh-narkar]

It would be great to add some unit test coverage for this. For example we could set output on the plugin logger and check if the decisions/status are being logged.

[anderseknert]

@ashutosh-narkar yeah I thought about that, but would it not essentially just be repeating the e2e test in a unit test format? I don't know too much about how codecov works, but does it not take all test types into account when calculating coverage?

[ashutosh-narkar]

@ashutosh-narkar yeah I thought about that, but would it not essentially just be repeating the e2e test in a unit test format? I don't know too much about how codecov works, but does it not take all test types into account when calculating coverage?

Re. codecov, me neither 🤷‍♂️ . I was thinking about a test where we set the regular logger to say error and then test out the plugin logger does the right thing.

[anderseknert]

That's pretty much what we do, no?

Oh well, I'll add a unit test for the status plugin since console logging seems untested there and thus we won't have to repeat the same test in another format. That should give us some codecov points too :)

[ashutosh-narkar]

That's pretty much what we do, no?

Oh well, I'll add a unit test for the status plugin since console logging seems untested there and thus we won't have to repeat the same test in another format. That should give us some codecov points too :)

My bad I missed that line. Sounds good. Thanks !

[anderseknert]

Unit test added. While it's good to have nonetheless it didn't do much in terms of pleasing codecov. I'm honestly lost here as the change itself is minimal, and all lines added are tested as far as I can tell.

[ashutosh-narkar]

lgtm

[tsandall]

@patrick-east PTAL