ast: Improve set implementation to memoize groudness #2966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously sets were not memoizing the groundness check so each call to `IsGround` would iterate until it found a non-ground term. In the worst-case, this would check the entire set. Because we call `IsGround` as part of the inner-loop of the `topdown.evalTerm#enumerate` code-path for sets, this introduced a cross-product! This commit improves the set implementation to maintain a bit that indicates whether the set is ground. When new elements are added to the set, the bit is set accordingly. This change provides a significant speedup for large sets. name old time/op new time/op delta SetIteration/10-20 28.6µs ± 1% 27.3µs ± 1% -4.65% (p=0.008 n=5+5) SetIteration/100-20 263µs ± 1% 152µs ± 1% -42.20% (p=0.008 n=5+5) SetIteration/1000-20 12.5ms ± 0% 1.4ms ± 1% -88.67% (p=0.008 n=5+5) SetIteration/10000-20 1.12s ± 0% 0.02s ± 1% -98.63% (p=0.008 n=5+5) Signed-off-by: Torin Sandall <torinsandall@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the commit message for details.