wasm: fix some string-handling issues in regex/glob matching #2998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsandall
previously approved these changes
Dec 10, 2020
srenatus
dismissed stale reviews from tsandall and koponen-styra
via
89cb4dc
|
@tsandall 🤦 forgot to push the commit. It's there now. Not become a hard requirement. |
…ngth string casts
Before, the opa_string_t's *char was used as-is; disregarding its length.
With certain inputs in consequent evaluations, this would end up using old
characters from a previous evaluation.
For example, evaluation
regex.match("^world$", input.message)
with input.message going through the sequence
"no-world"
"world"
would end up running the RE2 PartialMatch against the values
"no-world"
"worldrld"
and the second evaluation would thus wrongly fail.
Since glob.match is using regex.match underneath, it would show a similar
behaviour, as noted in open-policy-agent#2962
Note: for regex.is_valid, there is no test case. I had been seeing garbage
data trailing the pattern string before fixing this:
opa_print(): ^foobfdfd[ard�
Fixes open-policy-agent#2962.
Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
This is useful for debugging using print statements :D We should not have opa_println statements in our generated WASM code, but if we do, during development or debugging, the passed string will now be printed to stdout. Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
srenatus
force-pushed
the
sr/issue-2962/glob.match-wrong-results
branch
from
89cb4dc to
eaf516c
Compare
|
Squashed the builtin related fixes; kept the opa_println bit separate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the opa_string_t's *char was used as-is; disregarding its length.
With certain inputs in consequent evaluations, this would end up using old
characters from a previous evaluation.
For example, evaluation
with input.message going through the sequence
would end up running the RE2 PartialMatch against the values
and the second evaluation would thus wrongly fail.
Since glob.match is using regex.match underneath, it would show a similar
behaviour, as noted in #2962
Fixes #2962.
In the same spirit, changed some string usages in regex.is_valid and regex.find_all_string_submatch_n.
Also provides an
opa_printlnfunction for the WASM SDK... While that function is not used usually, with this change, it can be used for debugging purposes during development.