[issue #3661] http.send unix domain sockets

[kirk-patton]

No description provided.

[srenatus]

Thanks a lot for contributing! I've got a couple of nitpicks and a question re: http.Transport inline 👇 🙃

[srenatus]

Thanks for bearing with me. I'm afraid I've got a few more comments and questions 😅

[srenatus]

Sorry for the radio silence -- didn't manage to get back to this today. I'll take another look tomorrow.

[srenatus]

Thanks for bearing with me. I'm a little suspicious of the signal handler stuff -- do we really need that? That's the last bump, I think 🔍

Thanks again!

[srenatus]

Thanks for bearing with me. This looks good! A last nitpick, and I think we can get this merged 🎉

[srenatus]

Thanks for contributing! One last thing (promised!) -- could you please squash your commits and a add a little commit message describing the change, please? There's some guidance in CONTRIBUTING.md.

[kirk-patton]

ok, I think I got my commits squashed

[ashutosh-narkar]

@kirk-patton can you please update the http.send docs here and add a comment about the uds support.

Also you can squash your commits with something like git rebase -i HEAD~<number_of_your_commits> eg. git rebase -i HEAD~2

[kirk-patton]

@kirk-patton can you please update the http.send docs here and add a comment about the uds support.

Also you can squash your commits with something like git rebase -i HEAD~<number_of_your_commits> eg. git rebase -i HEAD~2

[kirk-patton]

@kirk-patton can you please update the http.send docs here and add a comment about the uds support.

Also you can squash your commits with something like git rebase -i HEAD~<number_of_your_commits> eg. git rebase -i HEAD~2

Certainly 👍

[tsandall]

@srenatus if this looks good, let's get this merged.

[kirk-patton]

---

@srenatus if this looks good, let's get this merged.

while attempting to call the http.send() function using unix://localhost/?socket=%F2tmp%F2http.socket, I am getting undefined back. It does not appear that the code I added is getting called. I need to take closer look.

[kirk-patton]

@srenatus if this looks good, let's get this merged.

while attempting to call the http.send() function using unix://localhost/?socket=%F2tmp%F2http.socket, I am getting undefined back. It does not appear that the code I added is getting called. I need to take closer look.

I double checked this morning and the cause of the issue I saw earlier was just that I needed to update my policy to use the new url format... It works

[srenatus]

I'm afraid I had forgotten about it, but @ashutosh-narkar is correct, this could use a bit of documentation. Would you mind adding some?

[kirk-patton]

I'm afraid I had forgotten about it, but @ashutosh-narkar is correct, this could use a bit of documentation. Would you mind adding some?

Yes, I will add that today. 👍

[ashutosh-narkar]

@kirk-patton thanks for addressing our comments. Can you please squash your commits and sign-off your final commit. This link should help.

Something like:

$ git fetch upstream
$ git rebase upstream/main
$ git rebase -i HEAD~39               # you can squash your commits here and reword the commit message
$ git push -f ......                            # then force push changes to your fork

Let us know if any questions.

[srenatus]

🎉 Thank you for contributing this, and thanks for bearing with us! 🚀 👏

[srenatus]

@kirk-patton the only thing that is a little off here is that github won't recognize the commit as yours -- I guess that's because the commit's email address hasn't been added to the list of addresses that are "yours" on github. https://docs.github.com/en/github/setting-up-and-managing-your-github-user-account/managing-email-preferences/setting-your-commit-email-address should have all the details, this is something that can be fixed retroactively if you don't mind having your yahoo email in github.