topdown: use function arity to determine captured output (partial eval) #3683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ehh, misclicked. Sorry for the noise. |
Before, we had been passing `len(e.terms)` to `saveCall`, thereby
sidestepping the checks that would get the output variable into the
save set.
In the problematic policy,
y = f(1)
count(y)
with
f(x) = [] { _ = input }
the call to `count(y)` would be mishandled: it would be evaluated,
since its arguments aren't in the saveset. Eval would fail because
its argument was a variable (see also
open-policy-agent#3680)
Fixes open-policy-agent#3681.
Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
srenatus
force-pushed
the
sr/issue-3681/shallow-pw-and-function
branch
from
72d3a54 to
228afa8
Compare
srenatus
changed the title
srenatus
changed the title
tsandall
approved these changes
Aug 12, 2021
jgchn
pushed a commit
to jgchn/opa
that referenced
this pull request
Aug 20, 2021
…-agent#3683) Before, we had been passing `len(e.terms)` to `saveCall`, thereby sidestepping the checks that would get the output variable into the save set. In the problematic policy, y = f(1) count(y) with f(x) = [] { _ = input } the call to `count(y)` would be mishandled: it would be evaluated, since its arguments aren't in the saveset. Eval would fail because its argument was a variable (see also open-policy-agent#3680) Fixes open-policy-agent#3681. Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
dolevf
pushed a commit
to dolevf/opa
that referenced
this pull request
Nov 4, 2021
…-agent#3683) Before, we had been passing `len(e.terms)` to `saveCall`, thereby sidestepping the checks that would get the output variable into the save set. In the problematic policy, y = f(1) count(y) with f(x) = [] { _ = input } the call to `count(y)` would be mishandled: it would be evaluated, since its arguments aren't in the saveset. Eval would fail because its argument was a variable (see also open-policy-agent#3680) Fixes open-policy-agent#3681. Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com> Signed-off-by: Dolev Farhi <farhi.dolev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, we had been passing
len(e.terms)tosaveCall, therebysidestepping the checks that would get the output variable into the
save set.
In the problematic policy,
with
the call to
count(y)would be mishandled: it would be evaluated,since its arguments aren't in the saveset. Eval would fail because
its argument was a variable (see also #3680)
Fixes #3681.