topdown/eval: conflict errors in functions when output not captured #3920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsandall
previously approved these changes
Oct 26, 2021
srenatus
force-pushed
the
sr/issue-3912/func-output-not-captured
branch
from
e2ce183 to
f51eb64
Compare
With func1.rego as
package test
r(x) {
data.test.q(x)
}
q(_) = true
q(_) = false
Before:
$ opa eval -fpretty -d func1.rego 'data.test.r(1)'
true
After:
$ opa eval -fpretty -d func1.rego 'data.test.r(1)'
1 error occurred: func1.rego:12: eval_conflict_error: functions must not produce multiple outputs for same inputs
Fixes open-policy-agent#3912.
Also adds a CHANGELOG item making the backwards-compat-breaking change
prominent, and sharing an example of how to fix it.
Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
srenatus
force-pushed
the
sr/issue-3912/func-output-not-captured
branch
from
f51eb64 to
94a9d6e
Compare
dolevf
pushed a commit
to dolevf/opa
that referenced
this pull request
Nov 4, 2021
…pen-policy-agent#3920) With func1.rego as package test r(x) { data.test.q(x) } q(_) = true q(_) = false Before: $ opa eval -fpretty -d func1.rego 'data.test.r(1)' true After: $ opa eval -fpretty -d func1.rego 'data.test.r(1)' 1 error occurred: func1.rego:12: eval_conflict_error: functions must not produce multiple outputs for same inputs Fixes open-policy-agent#3912. Also adds a CHANGELOG item making the backwards-compat-breaking change prominent, and sharing an example of how to fix it. Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com> Signed-off-by: Dolev Farhi <farhi.dolev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With func1.rego as
Before:
After:
Fixes #3912.
Signed-off-by: Stephan Renatus stephan.renatus@gmail.com