Code

ast: support dotted heads#4660

Code

Merged

srenatus merged 72 commits intoopen-policy-agent:mainopen-policy-agent/opa:mainfrom srenatus:sr/ast/dots-in-the-headsrenatus/opa:sr/ast/dots-in-the-headCopy head branch name to clipboardOct 14, 2022

+4,423-904

Commits

Commits on Oct 10, 2022

• ast+server: code cosmetics

  Show description for ccf93fa
  srenatus

  committed
  ccf93fa

  Copy full SHA for ccf93fa

• ast/parser: allow dots in rule heads

  Show description for f9c1ef4
  srenatus

  committed
  f9c1ef4

  Copy full SHA for f9c1ef4

• ast/compile: make conflict check stricter

  Show description for e855b9b
  srenatus

  committed
  e855b9b

  Copy full SHA for e855b9b

• ast/compile: fix getExports to fix resolveAllRefs

  Show description for bfe84fe
  srenatus

  committed
  bfe84fe

  Copy full SHA for bfe84fe

• WIP: resolve refs with heads

  Show description for 9f2f98e
  srenatus

  committed
  9f2f98e

  Copy full SHA for 9f2f98e

• getExports: return refs on same pkg instead of vars of leaves

  Show description for 21b033f
  srenatus

  committed
  21b033f

  Copy full SHA for 21b033f

• ast/parser_ext: lintfix

  Show description for f495cd0
  srenatus

  committed
  f495cd0

  Copy full SHA for f495cd0

• ast/index_test: add ref-rule cases

  Show description for 57f19c8
  srenatus

  committed
  57f19c8

  Copy full SHA for 57f19c8

• ast+topdown: breakthrough -- we can eval ref rules (again)

  Show description for d752a5c
  srenatus

  committed
  d752a5c

  Copy full SHA for d752a5c

• ast/parser: forbid multi-value rules with non-ground refs for now

  Show description for ac14e02
  srenatus

  committed
  ac14e02

  Copy full SHA for ac14e02

• ast/compile: sort RuleTree values

  Show description for 8c43e26
  srenatus

  committed
  8c43e26

  Copy full SHA for 8c43e26

• topdown/eval: don't panic if there's only one default rule

  Show description for 66d0379
  srenatus

  committed
  66d0379

  Copy full SHA for 66d0379

• ast/topdown: carry over head.Ref when saving support rule

  Show description for 465b033
  srenatus

  committed
  465b033

  Copy full SHA for 465b033

• ast/compile: accommodate Module{}s with missing Refs

  Show description for 7d8dff0
  srenatus

  committed
  7d8dff0

  Copy full SHA for 7d8dff0

• topdown/eval: correctly evaluate single/multi value rules

  Show description for e14907f
  srenatus

  committed
  e14907f

  Copy full SHA for e14907f

• format: adjust for ref heads

  Show description for 396ada6
  srenatus

  committed
  396ada6

  Copy full SHA for 396ada6

• ast: rename Head Ref -> Reference, introduce Ref() accessor for backcompat

  Show description for d862a9b
  srenatus

  committed
  d862a9b

  Copy full SHA for d862a9b

• topdown+format: Ref -> Reference fallout

  Show description for 65f5ac1
  srenatus

  committed
  65f5ac1

  Copy full SHA for 65f5ac1

• topdown/pe: deal with q[7] single-value rule case

  Show description for 2764978
  srenatus

  committed
  2764978

  Copy full SHA for 2764978

• refactor_test: update error

  Show description for f2e54ab
  srenatus

  committed
  f2e54ab

  Copy full SHA for f2e54ab

• ast/check+env: typecheck ref head rules properly

  Show description for fcab88e
  srenatus

  committed
  fcab88e

  Copy full SHA for fcab88e

• wip: more typechecking tests, adaptations

  Show description for 65b6e4a
  srenatus

  committed
  65b6e4a

  Copy full SHA for 65b6e4a

• ast/compile: make rule head ref checks stricter for now

  Show description for 3c2e42d
  srenatus

  committed
  3c2e42d

  Copy full SHA for 3c2e42d

• tester: adapt test rule name and report handling

  Show description for e050fc0
  srenatus

  committed
  e050fc0

  Copy full SHA for e050fc0

• testdata/partialobjectdoc: port wasm tests, because the type checker go stricter

  Show description for aef669d
  srenatus

  committed
  aef669d

  Copy full SHA for aef669d

• planner: adapt to ref heads

  Show description for d6c582b
  srenatus

  committed
  d6c582b

  Copy full SHA for d6c582b

• ast/compile: adjust things properly

  Show description for f24b6b5
  srenatus

  committed
  f24b6b5

  Copy full SHA for f24b6b5

• topdown/evalVirtualPartial: account for Head.Key being unset

  Show description for f9b1fc2
  srenatus

  committed
  f9b1fc2

  Copy full SHA for f9b1fc2

• ast/check_test: remove dead conditional

  Show description for ca0f7e1
  srenatus

  committed
  ca0f7e1

  Copy full SHA for ca0f7e1

• ast/check_test: dial back, we're doing strings only for now

  Show description for 15f784f
  srenatus

  committed
  15f784f

  Copy full SHA for 15f784f

• ast/compile: re-add head.Key into RewriteRefInHeads

  Show description for 66bdf64
  srenatus

  committed
  66bdf64

  Copy full SHA for 66bdf64

• planner: appease linter

  Show description for 929eb2c
  srenatus

  committed
  929eb2c

  Copy full SHA for 929eb2c

• compile/optimizer: fix module merging, adapt for ref rules

  Show description for a2b2475
  srenatus

  committed
  a2b2475

  Copy full SHA for a2b2475

• planner: fix plan for partial-obj rules

  Show description for 9e92c4c
  srenatus

  committed
  9e92c4c

  Copy full SHA for 9e92c4c

• planner: cut off last path piece if one of the rules had a var

  Show description for 1a0c432
  srenatus

  committed
  1a0c432

  Copy full SHA for 1a0c432

• wasm/opa_lookup: work with non-string pieces

  Show description for 4829995
  srenatus

  committed
  4829995

  Copy full SHA for 4829995

• planner: only check ref.GroundPrefix() for optimizations

  Show description for 7ab0adf
  srenatus

  committed
  7ab0adf

  Copy full SHA for 7ab0adf

• rego_test: un-skip failure

  Show description for a24cfc0
  srenatus

  committed
  a24cfc0

  Copy full SHA for a24cfc0

• ast/compile: properly hide system node only, expand tests a bit

  Show description for 49c57ed
  srenatus

  committed
  49c57ed

  Copy full SHA for 49c57ed

• ast/compile: dial back the sorting for TreeNode

  Show description for fc2170b
  srenatus

  committed
  fc2170b

  Copy full SHA for fc2170b

• repl: disable ref heads for interactive rule definitions

  Show description for d053158
  srenatus

  committed
  d053158

  Copy full SHA for d053158

• testdata/wasm-cases: add want_error_code

  Show description for 2a81609
  srenatus

  committed
  2a81609

  Copy full SHA for 2a81609

• ast/compile: make '(*TreeNode).Child' work with any hashable Value

  Show description for fe9a1cd
  srenatus

  committed
  fe9a1cd

  Copy full SHA for fe9a1cd

• ast/compile: move ref rewriting into earlier stage

  Show description for 709d51f
  srenatus

  committed
  709d51f

  Copy full SHA for 709d51f

• testdata/refheads: add regressions cases

  Show description for 781cf3a
  srenatus

  committed
  781cf3a

  Copy full SHA for 781cf3a

• oracle: cope with the rewriting we do for ref heads

  Show description for ac0555f
  srenatus

  committed
  ac0555f

  Copy full SHA for ac0555f

• ast/parser_ext: deal with naked 'input' and 'data' in RuleFromBody

  Show description for a789865
  srenatus

  committed
  a789865

  Copy full SHA for a789865

• ast/env: more cautious type creation for getRefRecExtent

  Show description for acabc96
  srenatus

  committed
  acabc96

  Copy full SHA for acabc96

• CHANGELOG.md: present ref heads

  Show description for ee467ee
  srenatus

  committed
  ee467ee

  Copy full SHA for ee467ee

• ast/visit: add (optional) ast.Head#Reference, fixing opa parse

  Show description for 79c8056
  srenatus

  committed
  79c8056

  Copy full SHA for 79c8056

• ast/compile: don't rewrite vars back inplace

  Show description for 4ddaff4
  srenatus

  committed
  4ddaff4

  Copy full SHA for 4ddaff4

• ast/transform: add Head#Reference handling

  Show description for 6347c72
  srenatus

  committed
  6347c72

  Copy full SHA for 6347c72

• testcases/regression: record peculiarity about ref rules and extents

  Show description for 3ce632c
  srenatus

  committed
  3ce632c

  Copy full SHA for 3ce632c

• ast/check: fix ref checker wrt changes to ref heads

  Show description for 9ba8728
  srenatus

  committed
  9ba8728

  Copy full SHA for 9ba8728

• ast/check: fix ref checker for non-var non-leaf values

  Show description for 47b888d
  srenatus

  committed
  47b888d

  Copy full SHA for 47b888d

• ast/check: rework ref checking

  Show description for 51a0240
  srenatus

  committed
  51a0240

  Copy full SHA for 51a0240

• ast/index_test: add test for ground/nonground case

  Show description for 96799c5
  srenatus

  committed
  96799c5

  Copy full SHA for 96799c5

• ast/compile: TODO -> NOTE about refSet

  Show description for 5973a0d
  srenatus

  committed
  5973a0d

  Copy full SHA for 5973a0d

• ast/conflicts: retract the other ref types, string prefixes only

  Show description for 138a842
  srenatus

  committed
  138a842

  Copy full SHA for 138a842

• ast/compiler: adapt error message to rules having refs

  Show description for eeb8cce
  srenatus

  committed
  eeb8cce

  Copy full SHA for eeb8cce

• ast/policy: cleanup comments

  Show description for 9af5810
  srenatus

  committed
  9af5810

  Copy full SHA for 9af5810

• non-leaf var infer

  Show description for b9f89a6
  srenatus

  committed
  b9f89a6

  Copy full SHA for b9f89a6

• ast/check: re-introduce non-failing leaf checks

  Show description for 289e4b1
  srenatus

  committed
  289e4b1

  Copy full SHA for 289e4b1

• ast/policy+compile: fix Vars visitor for head to fix safety check

  Show description for 8887916
  srenatus

  committed
  8887916

  Copy full SHA for 8887916

• ast/compile_test: rewrite TestCompilerRewriteTermsInHead

  Show description for d2546d9
  srenatus

  committed
  d2546d9

  Copy full SHA for d2546d9

• ast/parser: ensure invariant: genuine ref rules have no (Head).Name

  Show description for 6e42c8a
  srenatus

  committed
  6e42c8a

  Copy full SHA for 6e42c8a

• ast/policy: resolve TODO, (Head).String() for MV rules

  Show description for dce3eca
  srenatus

  committed
  dce3eca

  Copy full SHA for dce3eca

• topdown/eval: select 'virtual partial' code path for empty rule sets

  Show description for e17a0fa
  srenatus

  committed
  e17a0fa

  Copy full SHA for e17a0fa

• ast/parser_test: adjust rebase

  Show description for e84705b
  srenatus

  committed
  e84705b

  Copy full SHA for e84705b

• ast/compile: rewrite so that objects don't become rule tree keys

  Show description for b5e6177
  srenatus

  committed
  b5e6177

  Copy full SHA for b5e6177

Commits on Oct 13, 2022

• Merge branch 'main' into sr/ast/dots-in-the-head

  srenatus

  authored
  fd452ec

  Copy full SHA for fd452ec

Commits on Oct 14, 2022

• Merge branch 'main' into sr/ast/dots-in-the-head

  srenatus

  authored
  5934efa

  Copy full SHA for 5934efa