docs+build: Restore diff-against-main behavior for PRs. #5145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philip Conrad <philipaconrad@gmail.com>
|
IIRC main is a very old ref in netlify, which is why that didn't work out. |
|
Oh no! I remember in the older issue there was a note that we couldn't fix |
|
Let's not do this. I've changed the notification settings in netlify so that the latest deployed preview is easier to find, see #5151 for an example. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit partially reverts #5045, allowing us to correctly diff against
mainduring PRs, and against cached builds the rest of the time.