planner: when planning a ref's extent, plan the keys as values #5257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The compiler ensures that all the keys we see there are scalars. For strings,
nothing changes -- they're handled just like before -- but this now also allows
numbers and booleans.
An example policy that exploded with a panic before is
package p
a[0] = true
when querying the full extent of `data.p` or `data.p.a`.
Fixes open-policy-agent#5252.
Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
anderseknert
approved these changes
Oct 17, 2022
| - | | ||
| package test | ||
| p[0] = true |
There was a problem hiding this comment.
Not a fan of :=, are you? ;)
There was a problem hiding this comment.
lol I look at it like the compiler does. 😜
byronic
pushed a commit
to byronic/opa
that referenced
this pull request
Oct 17, 2022
…policy-agent#5257) The compiler ensures that all the keys we see there are scalars. For strings, nothing changes -- they're handled just like before -- but this now also allows numbers and booleans. An example policy that exploded with a panic before is package p a[0] = true when querying the full extent of `data.p` or `data.p.a`. Fixes open-policy-agent#5252. Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com> Signed-off-by: Byron Lagrone <byron.lagrone@seqster.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compiler ensures that all the keys we see there are scalars. For strings, nothing changes -- they're handled just like before -- but this now also allows numbers and booleans.
An example policy that exploded with a panic before is
when querying the full extent of
data.pordata.p.a.Fixes #5252.