Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.49.0 #5626

Closed

Conversation

philipaconrad
Copy link
Contributor

ℹ️ This is the draft of our v0.49.0 release notes. Comments and edit suggestions welcome! ✍️

This was a light month, so the release notes are much shorter than usual. 😄

I didn't see any major features to call out, but @ashutosh-narkar might have some ideas for what to add if we want a callout at the top of the block.

@netlify
Copy link

netlify bot commented Feb 3, 2023

Deploy Preview for openpolicyagent ready!

Name Link
🔨 Latest commit 9b8d23b
🔍 Latest deploy log https://app.netlify.com/sites/openpolicyagent/deploys/63e194a7f39b5100098243aa
😎 Deploy Preview https://deploy-preview-5626--openpolicyagent.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ashutosh-narkar
Copy link
Member

Thanks for putting this together @philipaconrad!

@anderseknert
Copy link
Member

Nice! Any chance we can have #5576 included in v0.49.0?

srenatus
srenatus previously approved these changes Feb 3, 2023
Copy link
Contributor

@srenatus srenatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for putting it together.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
### Website + Ecosystem

- Ecosystem:
- ccbr (authored by @niuzhi)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to have PR links for all changes in the changelog? Worry that some might be missing context otherwise.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have thought so! But apparently we've consistently stripped those from the CHANGELOG for many releases. I don't know the reasoning behind why, but I've kept the formatting to match what's there.

@philipaconrad
Copy link
Contributor Author

@anderseknert Re: #5576, I can add that later this evening, or you can commit directly to this branch (I think you should have write access).

@philipaconrad
Copy link
Contributor Author

Also, there's a weird Git error in the Go build targets; I don't have time before my flight to dig much further on it. If any of you all have time to figure out what's causing it, I'll do whatever PR cleanup is needed later this evening.

@charlieegan3
Copy link
Contributor

Regarding #5576, there is still this comment that I'd like some input on:
#5576 (comment). However, I can change that tomorrow quite quickly if need be.

ashutosh-narkar
ashutosh-narkar previously approved these changes Feb 6, 2023
@ashutosh-narkar
Copy link
Member

@philipaconrad the notes lgtm. Can you add this change to the notes and cut the release? Thanks!

Signed-off-by: Philip Conrad <philipaconrad@gmail.com>
Signed-off-by: Philip Conrad <philipaconrad@gmail.com>
Signed-off-by: Philip Conrad <philipaconrad@gmail.com>
Signed-off-by: Philip Conrad <philipaconrad@gmail.com>
@philipaconrad
Copy link
Contributor Author

@ashutosh-narkar It is done. 👍

I don't feel safe cutting the release tag until I know CI won't stop the image build/deploys for the docs/binaries. I'm going to wait until I either see things go green, or start dealing with the Git issue myself.

@philipaconrad
Copy link
Contributor Author

philipaconrad commented Feb 6, 2023

CI failures seem related to runner-images issue, caused by Git in recent versions being incredibly fussy about who owns which directory in a repo.

Signed-off-by: Philip Conrad <philipaconrad@gmail.com>
@philipaconrad
Copy link
Contributor Author

Everything seems okay now, except for the Windows build, which seems to have some weird issues going on related to permissions?

@ashutosh-narkar
Copy link
Member

ashutosh-narkar commented Feb 7, 2023

Everything seems okay now, except for the Windows build, which seems to have some weird issues going on related to permissions?

@philipaconrad did you change something to make the other two previously failing checks to now pass?

Just saw the Makefile change. Anything to be done similarly for Windows?

@ashutosh-narkar
Copy link
Member

For Windows the following seemed to work. Basically keeping CI_GOLANG_DOCKER_MAKE the same and moving git config --global --add safe.directory /src under the ci-build-windows target.

@ashutosh-narkar
Copy link
Member

Closing in favor of #5634.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants