-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.49.0 #5626
Release v0.49.0 #5626
Conversation
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Thanks for putting this together @philipaconrad! |
Nice! Any chance we can have #5576 included in v0.49.0? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks for putting it together.
### Website + Ecosystem | ||
|
||
- Ecosystem: | ||
- ccbr (authored by @niuzhi) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to have PR links for all changes in the changelog? Worry that some might be missing context otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have thought so! But apparently we've consistently stripped those from the CHANGELOG for many releases. I don't know the reasoning behind why, but I've kept the formatting to match what's there.
@anderseknert Re: #5576, I can add that later this evening, or you can commit directly to this branch (I think you should have write access). |
Also, there's a weird Git error in the Go build targets; I don't have time before my flight to dig much further on it. If any of you all have time to figure out what's causing it, I'll do whatever PR cleanup is needed later this evening. |
Regarding #5576, there is still this comment that I'd like some input on: |
@philipaconrad the notes lgtm. Can you add this change to the notes and cut the release? Thanks! |
Signed-off-by: Philip Conrad <philipaconrad@gmail.com>
Signed-off-by: Philip Conrad <philipaconrad@gmail.com>
Signed-off-by: Philip Conrad <philipaconrad@gmail.com>
Signed-off-by: Philip Conrad <philipaconrad@gmail.com>
dfa5a80
to
af84320
Compare
@ashutosh-narkar It is done. 👍 I don't feel safe cutting the release tag until I know CI won't stop the image build/deploys for the docs/binaries. I'm going to wait until I either see things go green, or start dealing with the Git issue myself. |
CI failures seem related to runner-images issue, caused by Git in recent versions being incredibly fussy about who owns which directory in a repo. |
Signed-off-by: Philip Conrad <philipaconrad@gmail.com>
d9f8232
to
9b8d23b
Compare
Everything seems okay now, except for the Windows build, which seems to have some weird issues going on related to permissions? |
Just saw the Makefile change. Anything to be done similarly for Windows? |
For Windows the following seemed to work. Basically keeping |
Closing in favor of #5634. |
ℹ️ This is the draft of our
v0.49.0
release notes. Comments and edit suggestions welcome! ✍️This was a light month, so the release notes are much shorter than usual. 😄
I didn't see any major features to call out, but @ashutosh-narkar might have some ideas for what to add if we want a callout at the top of the block.