cmd: add watch mode to opa test command #5812
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: open-policy-agent#1719 Signed-off-by: Johan Fylling <johan.dev@fylling.se>
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
johanfylling
commented
Apr 3, 2023
| } | ||
| } | ||
|
|
||
| // It's up to onReload to update the store with loaded content |
There was a problem hiding this comment.
This is my biggest grievance with the current approach. We're doing some updates to the store above, but not all necessary updates. Either, we should be doing all updates, or none.
The problem with doing all updates here is that currently, some of that, such as bundle activation, is deep within the compile/run of running/testing a policy. This could be refactored, to some extent, but I'm weary of creating even more paths through the code than already exist.
|
This pull request has been automatically marked as stale because it has not had any activity in the last 30 days. |
|
Closing in favor of #5950. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring file-watching functionality in
runcommand, to be reused intestcommand.This is WiP. It's currently a bit messy, but gets the job done.
Fixes: #1719