make func newDescriptor public

[antgubarev]

I compile bundle from key-value storage. But I can't implement DirectoryLoader for that beacause newDescriptor is private. I would like to use bundle.CustomReader. Is it possible?
Thanks!

[anderseknert]

Hi @antgubarev 👋 And thanks for submitting this. Can you help me understand why you need newDescriptor to be public for your custom implementation of a directory loader? The Descriptor struct is public already, so could you not just use that directly?

[antgubarev]

Hi @antgubarev 👋 And thanks for submitting this. Can you help me understand why you need newDescriptor to be public for your custom implementation of a directory loader? The Descriptor struct is public already, so could you not just use that directly?

Hi @anderseknert !
I try to implement DirectoryLoader interface. Method NextFile returns Descriptor https://github.com/open-policy-agent/opa/blob/main/bundle/file.go#L123 . But I can't set descriptor's fields outside the bundle package. It's private https://github.com/open-policy-agent/opa/blob/main/bundle/file.go#L24

[anderseknert]

Ah, right — I didn't think of checking the fields. I don't mind making the constructor public, not sure if anyone else has objections.

The DCO requirement needs to be fixed though. Just sign the commit like:

git commit --amend --signoff
git push --force

[ashutosh-narkar]

Seems reasonable. We should probably make withCloser public too.

[srenatus]

Seems reasonable. We should probably make withCloser public too.

Hmm we could also check if we've got an io.Reader that also an io.Closer and call its Close() opportunistically in (*Descriptor).Close(). Then we wouldn't need the withCloser anymore.

[netlify]

✅ Deploy Preview for openpolicyagent ready!

Name	Link
🔨 Latest commit	6823610
🔍 Latest deploy log	https://app.netlify.com/sites/openpolicyagent/deploys/65a0298eca9358000861fd08
😎 Deploy Preview	https://deploy-preview-6517--openpolicyagent.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[antgubarev]

@anderseknert I fixed my commit and made WithCloser public too

[ashutosh-narkar]

@antgubarev can you please squash your commits and fix the sign-off ? We can then get this in.

[antgubarev]

@ashutosh-narkar Sorry) Done.

[ashutosh-narkar]

@antgubarev can you please fix the DCO again. Not sure what's happening.

[antgubarev]

@antgubarev can you please fix the DCO again. Not sure what's happening.

@ashutosh-narkar Fixed.