Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding integration for OPA permissions wrapper #6629

Conversation

Parsifal-M
Copy link
Contributor

Why the changes in this PR are needed?

Adding an integration 😄

What are the changes in this PR?

Adding my OPA Permissions Wrapper plugin that integrates with Backstage to the ecosystem!

Notes to assist PR review:

I have followed the instructions as advised in https://www.openpolicyagent.org/ecosystem/ please let me know if I missed anything or did anything incorrectly!

Further comments:

Thank you! 🚀

Signed-off-by: Peter Macdonald <macdonald.peter90@gmail.com>
Copy link

netlify bot commented Mar 13, 2024

Deploy Preview for openpolicyagent ready!

Name Link
🔨 Latest commit bafa9a6
🔍 Latest deploy log https://app.netlify.com/sites/openpolicyagent/deploys/65f2041012c0a600087406cd
😎 Deploy Preview https://deploy-preview-6629--openpolicyagent.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Peter Macdonald <macdonald.peter90@gmail.com>
Copy link
Member

@anderseknert anderseknert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Peter! Just some suggestions.

- petermacdonald
tutorials: # optional, links to tutorials for the integration
- https://github.com/Parsifal-M/backstage-opa-plugins/blob/main/plugins/permission-backend-module-opa-wrapper/README.md
code: # optional, links to code for the integration
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove the comment from here and line 10, as that's fairly obvious :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops 🧹

@@ -0,0 +1,15 @@
---
title: OPA Permissions Wrapper
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the title and logo should be for Backstage, as that's what the integration is built for. "OPA Perissions Wrapper" isn't providing any clues as to what this is about.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point 😅

Signed-off-by: Peter Macdonald <macdonald.peter90@gmail.com>
Copy link
Member

@anderseknert anderseknert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@anderseknert anderseknert merged commit 1a1ff2b into open-policy-agent:main Mar 13, 2024
25 of 26 checks passed
tsidebottom pushed a commit to tsidebottom/opa- that referenced this pull request Apr 17, 2024
Adding integration for Backstage

Signed-off-by: Peter Macdonald <macdonald.peter90@gmail.com>
Signed-off-by: Thomas Sidebottom <thomas.sidebottom@va.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants