-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding integration for OPA permissions wrapper #6629
Adding integration for OPA permissions wrapper #6629
Conversation
Signed-off-by: Peter Macdonald <macdonald.peter90@gmail.com>
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Peter! Just some suggestions.
- petermacdonald | ||
tutorials: # optional, links to tutorials for the integration | ||
- https://github.com/Parsifal-M/backstage-opa-plugins/blob/main/plugins/permission-backend-module-opa-wrapper/README.md | ||
code: # optional, links to code for the integration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove the comment from here and line 10, as that's fairly obvious :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woops 🧹
@@ -0,0 +1,15 @@ | |||
--- | |||
title: OPA Permissions Wrapper |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the title and logo should be for Backstage, as that's what the integration is built for. "OPA Perissions Wrapper" isn't providing any clues as to what this is about.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point 😅
Signed-off-by: Peter Macdonald <macdonald.peter90@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Adding integration for Backstage Signed-off-by: Peter Macdonald <macdonald.peter90@gmail.com> Signed-off-by: Thomas Sidebottom <thomas.sidebottom@va.gov>
Why the changes in this PR are needed?
Adding an integration 😄
What are the changes in this PR?
Adding my OPA Permissions Wrapper plugin that integrates with Backstage to the ecosystem!
Notes to assist PR review:
I have followed the instructions as advised in https://www.openpolicyagent.org/ecosystem/ please let me know if I missed anything or did anything incorrectly!
Further comments:
Thank you! 🚀